amended mkdocs missing message to allign with sphinx #12012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silentfatez
force-pushed
the
mkdocs-build-missing-yaml-message
branch
from
4290a39 to
202ce9e
Compare
silentfatez
force-pushed
the
mkdocs-build-missing-yaml-message
branch
from
202ce9e to
ade2e8f
Compare
silentfatez
force-pushed
the
mkdocs-build-missing-yaml-message
branch
from
2a01a33 to
34092ee
Compare
|
I have added made changes and included for the missing yaml message. However, when i added the linkage to the missing yaml mesage, it seems that it breaks some of the tests in test_build_tasks.py I am unsure of how to fix this and what is the cause of it, is it possible for some guidance on this? |
| @@ -80,6 +80,11 @@ def get_yaml_config(self): | |||
| def show_conf(self): | |||
| """Show the current ``mkdocs.yaml`` being used.""" | |||
| # Write the mkdocs.yml to the build logs | |||
| if not os.path.exists(self.yaml_file): | |||
There was a problem hiding this comment.
I think this is the only logic we need here? I'm not sure what the rest of the PR is doing during the actual build?
|
@silentfatez Hi, are you still planning to work on this PR? There is a some review on it that you may want to take on so we can move forward with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amended error message to allign with sphinx missing conf.py message for mkdocs.yaml
This is to address
Build: "Unknown" error when mkdocs.yml is not found #11937
Closes #11937